Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write to backup log file when backup is finished #2

Open
djmattyg007 opened this issue Sep 27, 2021 · 4 comments
Open

Write to backup log file when backup is finished #2

djmattyg007 opened this issue Sep 27, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@djmattyg007
Copy link

IMO it would be more useful if backups were only logged to the backup log file once the backup is finished. It would be perfectly fine for both commencement and completion to be logged, but at the very least completion should be explicitly logged.

@SparklingComet
Copy link
Owner

Fair enough, I will add a setting to toggle the log message both before and after the completion.

@SparklingComet SparklingComet added the enhancement New feature or request label Sep 29, 2021
@SparklingComet
Copy link
Owner

There has been a change of plans, commencement will not be logged anymore, only the end result (whether success or failure).

@djmattyg007
Copy link
Author

How come? I think it would definitely be useful to have both. Knowing how long backups are taking is very valuable.

@SparklingComet
Copy link
Owner

I agree, but I’ll push commencement logs back to the release after the next because I wish to rewrite the logging system so it doesn’t make sense to implement something that will be rewritten in a couple weeks.

The next release will thus only contain the end log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants