Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Wrong TTL config key used #4226

Closed
1 task done
ngiraud opened this issue Oct 24, 2024 · 2 comments
Closed
1 task done

[Bug]: Wrong TTL config key used #4226

ngiraud opened this issue Oct 24, 2024 · 2 comments

Comments

@ngiraud
Copy link
Contributor

ngiraud commented Oct 24, 2024

Is the bug applicable and reproducable to the latest version of the package and hasn't it been reported before?

  • Yes, it's still reproducable

What version of Laravel Excel are you using?

3.1.58

What version of Laravel are you using?

9.52.16

What version of PHP are you using?

8.1

Describe your issue

Hello,

I think there is an issue with the name of the default_ttl cache config set here.
The key is 'default_ttl' => 10800, but I can see in the CacheManager that the config cache key used is config('excel.cache.ttl').
I think this leads to have keys saved forever.

How can the issue be reproduced?

Create an export with the illuminate driver set in the config.

What should be the expected behaviour?

The key should be ttl or the CacheManager should be modified with default_ttl

@ngiraud ngiraud added the bug label Oct 24, 2024
@patrickbrouwers
Copy link
Member

Best to create a PR

@ngiraud ngiraud mentioned this issue Oct 25, 2024
4 tasks
@stale stale bot added the stale label Dec 28, 2024
Copy link

stale bot commented Dec 31, 2024

This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions.

@stale stale bot closed this as completed Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants