Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we still need the preprocessing steps? #336

Open
Jieran-S opened this issue Jan 9, 2025 · 2 comments
Open

Do we still need the preprocessing steps? #336

Jieran-S opened this issue Jan 9, 2025 · 2 comments

Comments

@Jieran-S
Copy link
Member

Jieran-S commented Jan 9, 2025

  • Should we remove the optargs for methods?
@shdam
Copy link
Contributor

shdam commented Jan 22, 2025

I would say for the native implementation it is confusing to keep the optargs.
I think the centralized vs native implementation is a very interesting discussion, and I could envision some reviewers being stubborn about us also testing the centralized preprocessing approach. Therefore, I suggest keeping the optargs in a separate branch, but otherwise removing them.
My 2 cents.

@Jieran-S
Copy link
Member Author

Sounds good & I agree. This is also linked to #333 on how we should trim the branches. Will mention it there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants