Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add sd-jwt to issuer callback #86

Conversation

TimoGlastra
Copy link
Collaborator

Adds CompactSdJwtVc to the return type of the signer callback.

It doesn't really impact things as you could already return CompactJwt (a string) and CompactSdJwtVc is also a string, but it's good when looking at the implemetnation for reference to see that SD-JWT is also supported

Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nklomp nklomp merged commit 89f78b3 into Sphereon-Opensource:develop Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants