Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added jwt payload to the externalOIDFIdentifier.ts #55

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

chore: Added jwt payload to the externalOIDFIdentifier.ts #55

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b80b1cf
chore: Added jwt payload to the externalOIDFIdentifier.ts
Nov 28, 2024
8c2ba79
fix: Fixed jwt decoding
Nov 28, 2024
67b5af1
fix: Fixed jwt type
Nov 28, 2024
9afc487
refactor: Replaced @veramo/utils with uint8arrays
Dec 3, 2024
333a70c
Merge branch 'develop' of https://github.com/Sphereon-Opensource/SSI-…
Dec 3, 2024
f1862bf
fix: merging issue
Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/identifier-resolution/src/functions/externalOIDFIdentifier.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { IAgentContext } from '@veramo/core'
import { IOIDFClient } from '@sphereon/ssi-sdk.oidf-client'
import { contextHasPlugin } from '@sphereon/ssi-sdk.agent-config'
import { IJwsValidationResult } from '../types/IJwtService'
import {decodeBase64url} from "@veramo/utils";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not include veramo utils. It deps on almost everything in veramo.

We have functions for base64 url decoding. And otherwise it is as simple as u8a.fromString(input, 'base64url')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced with uint8arrays as suggested


/**
* Resolves an OIDF Entity ID against multiple trust anchors to establish trusted relationships
Expand Down Expand Up @@ -71,7 +72,7 @@ export async function resolveExternalOIDFEntityIdIdentifier(
continue
}

payload = JSON.parse(jwtVerifyResult.jws.payload)
payload = JSON.parse(decodeBase64url(jwtVerifyResult.jws.payload))
const signature = jwtVerifyResult.jws.signatures[0]
if (signature.identifier.jwks.length === 0) {
errorList[trustAnchor] = 'No JWK was present in the trust anchor signature'
Expand Down
Loading