Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BiometricUtils implemented but not used #156

Open
arheom opened this issue Aug 3, 2023 · 6 comments
Open

BiometricUtils implemented but not used #156

arheom opened this issue Aug 3, 2023 · 6 comments

Comments

@arheom
Copy link

arheom commented Aug 3, 2023

Was looking to add biometrics to authenticate the user (mobile app only) when accepting and sharing credentials. But I have seen the react-native-fingerprint-scanner is imported (but no longer maintained by the creators) and used inside the BiometricUtils.ts file, but the file I dont see it used anywhere.

So, does the mobile app support biometrics, but needs to be configured somewhere? Or you stopped it to implement a more secured one (with a server side challenge, like FIDO)? Or, shall I try to implement the mobile app biometrics approach and create a PR for it?

@BtencateSphereon
Copy link
Contributor

BtencateSphereon commented Aug 3, 2023

Hi @arheom, using biometrics was briefly implemented for authenticating but we are still working on refactoring parts of the code. Currently only the pin code is working and this will be extended with biometrics in the future. As you mentioned react-native-fingerprint-scanner is no longer maintained, so we are looking for a replacement.

@mariomurrent-softwaresolutions

@BtencateSphereon have you thought about considering https://www.npmjs.com/package/react-native-biometrics ?

Another thing, could it be, that the pin code fields do not work on the iOS Simulator?

@BtencateSphereon
Copy link
Contributor

BtencateSphereon commented Aug 4, 2023

@mariomurrent-softwaresolutions thanks for the suggestion. We will definitely take a look at using https://www.npmjs.com/package/react-native-biometrics.

As far as I am aware, there should not be any issues with the pin codes on iOS. What issues are you experiencing? Then we can take a look.

@nklomp
Copy link
Contributor

nklomp commented Aug 4, 2023

@arheom If you are willing and able to integrate a biometric approach that for sure would be appreciated, given we have some other short-term priorities at the moment.

Indeed something like FIDO is on our wish-list, but we first want to start with biometrics.
For the long term we are also working together with a partner on continuous authentication. Meaning depending on the environment we keep track of an authentication score, based on interactions, behavior, auth threshold, to either not need re-authentication.

@nklomp
Copy link
Contributor

nklomp commented Aug 4, 2023

@mariomurrent-softwaresolutions thanks for the suggestion. We will definitely take a look at using https://www.npmjs.com/package/react-native-biometrics.

As far as I am aware, there should not be any issues with the pin codes on iOS. What issues are you experiencing? Then we can take a look.

@mariomurrent-softwaresolutions As Bram mentioned we are not aware of issues with pincodes not working on iOS, so could you provide us with some more details.

We are aware of some usability issues with the wallet locking too soon on iOS and deeplinks not working (same-device flow). The latter will be fixed soon, the former is a bit more work.

@mariomurrent-softwaresolutions

@nklomp @BtencateSphereon its not on the real device, just on the simulator 😊 so ok the iPhone it works perfectly.

On the simulator the input triggers a backspace immediately after entering a number. But this is a known issue of the react native input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants