Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-selection on presentation definition issues #165

Open
ejossev opened this issue Oct 11, 2023 · 1 comment
Open

Pre-selection on presentation definition issues #165

ejossev opened this issue Oct 11, 2023 · 1 comment

Comments

@ejossev
Copy link

ejossev commented Oct 11, 2023

When trying to request presentation using presentation definition v1 (does v2 works?), the wallet starts with the Required credential screen, where there is one selection element for each input descriptor. However, for most input descriptors, after clicking, it preselects and allows to select also credentials, that do not match the input descriptor. E.g. input descriptor like this:

    {
      "id": "Request content",
      "purpose": "Specify your request",
      "name": "Request content",
      "group": [
        "B"
      ],
      "schema": [
        {
          "uri": "%s"
        }
      ],
      "constraints": {
        "fields": [
          {
            "path": [
              "$.type.*"
            ],
            "filter": {
              "type": "string",
              "pattern": "^RequestCredential$"
            },
            "purpose": "The claim must be from one of the specified issuers",
            "id": "1f44d55f-f161-4938-a659-f8026467f126"
          }
        ]
      }
    }

)
preselects also the default Identity Credential. Strange thing is, would I click on these non-matching credential, then Select, then Accept, the Share button is shaded. So only pre-selection is affected, the check before sending works.

@nklomp
Copy link
Contributor

nklomp commented Oct 11, 2023

Thanks for reporting. This is indeed something we have noticed in latest version as well and is in our backlog.

We are currently adding support for OID4VP version 18 and SIOP v12. Then we will do some refactoring on the way we are handling OID4VC, making it more lose coupled. We will probably have a quick look before doing that to determine whether it is a small issue, or just do it altogether with the refactor we need to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants