Skip to content

Commit

Permalink
Avoid printing messages to the console. (#365)
Browse files Browse the repository at this point in the history
  • Loading branch information
Hixie authored Mar 31, 2023
1 parent 44cc358 commit 043e0ed
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
12 changes: 12 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,18 @@ GitHub.dart is committed to efficiency as much as possible. If your code is not

Pull Request rejections are not a bad thing. It just means you need to fix something. Perhaps it is important to define 'rejection' as it is used in this case. A rejection is when a GitHub.dart committer comments on a Pull Request with a comment like 'rejected due to incorrect formatting'.

## Tests

To run the complete test suite you will need to install
`octokit/fixtures-server`.

```
npm install --global @octokit/fixtures-server
```

Tests can be run using `make test`, which will start up a local mock
GitHub and execute tests against it using your localhost port 3000.

## Contacting Us

- IRC: `#directcode on irc.esper.net and irc.freenode.net`
Expand Down
3 changes: 1 addition & 2 deletions lib/src/common/github.dart
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,6 @@ class GitHub {
/// Internal method to handle status codes
///
Never handleStatusCode(http.Response response) {
print(response.body);
String? message = '';
List<Map<String, String>>? errors;
if (response.headers['content-type']!.contains('application/json')) {
Expand All @@ -450,7 +449,7 @@ class GitHub {
}
}
} catch (ex) {
print(ex);
throw UnknownError(this, ex.toString());
}
}
switch (response.statusCode) {
Expand Down

0 comments on commit 043e0ed

Please sign in to comment.