From a4fd6952333f5a8129f6a73e8ce31279e8f5e180 Mon Sep 17 00:00:00 2001
From: Florent Morselli <florent.morselli@spomky-labs.com>
Date: Thu, 21 Mar 2024 07:08:05 +0100
Subject: [PATCH] features: CachePlugin and CacheStrategy are now interfaces

---
 src/Command/ListCacheStrategiesCommand.php | 56 ++++++++++++----------
 1 file changed, 31 insertions(+), 25 deletions(-)

diff --git a/src/Command/ListCacheStrategiesCommand.php b/src/Command/ListCacheStrategiesCommand.php
index 52075b5..e795c5d 100644
--- a/src/Command/ListCacheStrategiesCommand.php
+++ b/src/Command/ListCacheStrategiesCommand.php
@@ -4,11 +4,13 @@
 
 namespace SpomkyLabs\PwaBundle\Command;
 
+use SpomkyLabs\PwaBundle\CachingStrategy\CacheStrategy;
 use SpomkyLabs\PwaBundle\CachingStrategy\HasCacheStrategies;
 use SpomkyLabs\PwaBundle\CachingStrategy\WorkboxCacheStrategy;
 use SpomkyLabs\PwaBundle\WorkboxPlugin\CachePlugin;
 use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
@@ -39,35 +41,39 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             ['Name', 'Strategy', 'URL pattern', 'Enabled', 'Workbox?', 'Plugins', 'Preload URLs', 'Options']
         );
         foreach ($this->services as $service) {
-            $strategies = $service->getCacheStrategies();
-            foreach ($strategies as $strategy) {
-                if ($strategy instanceof WorkboxCacheStrategy) {
-                    $table->addRow([
-                        $strategy->getName(),
-                        $strategy->strategy,
-                        $strategy->matchCallback,
-                        $strategy->isEnabled() ? 'Yes' : 'No',
-                        $strategy->needsWorkbox() ? 'Yes' : 'No',
-                        Yaml::dump(array_map(fn (CachePlugin $v): string => $v->getName(), $strategy->getPlugins())),
-                        count($strategy->getPreloadUrls()),
-                        Yaml::dump($strategy->getOptions()),
-                    ]);
-                } else {
-                    $table->addRow([
-                        $strategy->getName(),
-                        '---',
-                        '---',
-                        $strategy->isEnabled() ? 'Yes' : 'No',
-                        $strategy->needsWorkbox() ? 'Yes' : 'No',
-                        '',
-                        '',
-                        '',
-                    ]);
-                }
+            foreach ($service->getCacheStrategies() as $strategy) {
+                $this->processStrategy($strategy, $table);
             }
         }
         $table->render();
 
         return self::SUCCESS;
     }
+
+    private function processStrategy(CacheStrategy $strategy, Table $table): void
+    {
+        if ($strategy instanceof WorkboxCacheStrategy) {
+            $table->addRow([
+                $strategy->getName(),
+                $strategy->strategy,
+                $strategy->matchCallback,
+                $strategy->isEnabled() ? 'Yes' : 'No',
+                $strategy->needsWorkbox() ? 'Yes' : 'No',
+                Yaml::dump(array_map(fn (CachePlugin $v): string => $v->getName(), $strategy->getPlugins())),
+                count($strategy->getPreloadUrls()),
+                Yaml::dump($strategy->getOptions()),
+            ]);
+        } else {
+            $table->addRow([
+                $strategy->getName(),
+                '---',
+                '---',
+                $strategy->isEnabled() ? 'Yes' : 'No',
+                $strategy->needsWorkbox() ? 'Yes' : 'No',
+                '',
+                '',
+                '',
+            ]);
+        }
+    }
 }