Better Service Worker

Spomky-Labs · Feb 6, 2024 · adb82b9 · adb82b9
1 parent cda04c6
commit adb82b9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -95,11 +95,6 @@ parameters:
 			count: 1
 			path: src/Command/CreateServiceWorkerCommand.php
 
-		-
-			message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, array\\|string given\\.$#"
-			count: 1
-			path: src/Command/CreateServiceWorkerCommand.php
-
 		-
 			message: "#^Parameter \\#2 \\$targetFile of method Symfony\\\\Component\\\\Filesystem\\\\Filesystem\\:\\:copy\\(\\) expects string, mixed given\\.$#"
 			count: 1
@@ -488,9 +483,4 @@ parameters:
 		-
 			message: "#^Method SpomkyLabs\\\\PwaBundle\\\\Normalizer\\\\UrlNormalizer\\:\\:supportsNormalization\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#"
 			count: 1
-			path: src/Normalizer/UrlNormalizer.php
-
-		-
-			message: "#^Parameter \\#1 \\$string of function mb_strlen expects string, string\\|null given\\.$#"
-			count: 1
-			path: src/Subscriber/PwaDevServerSubscriber.php
+			path: src/Normalizer/UrlNormalizer.php
diff --git a/src/Subscriber/PwaDevServerSubscriber.php b/src/Subscriber/PwaDevServerSubscriber.php
@@ -151,7 +151,7 @@ private function serveWorkboxFile(RequestEvent $event, string $pathInfo): void
         if (str_contains($pathInfo, '/..')) {
             return;
         }
-        $asset = mb_substr($pathInfo, mb_strlen($this->workboxPublicUrl));
+        $asset = mb_substr($pathInfo, mb_strlen((string) $this->workboxPublicUrl));
         $resource = sprintf('@SpomkyLabsPwaBundle/Resources/workbox-v%s%s', $this->workboxVersion, $asset);
         $resourcePath = $this->fileLocator->locate($resource, null, false);
         if (is_array($resourcePath)) {