From d1d91952cdd16ad2ce2a5a660fd7163032e02aa0 Mon Sep 17 00:00:00 2001
From: Florent Morselli <florent.morselli@spomky-labs.com>
Date: Mon, 15 Apr 2024 15:30:56 +0200
Subject: [PATCH] Update bootstrap path and add manifest credential use

The bootstrap path in phpunit.xml.dist has been updated to 'tests/autoload.php'. A useCredentials option has been added to the PWA manifest allowing the manifest to be fetched with credentials, enhancing website security. Also, an autoload.php file has been added to facilitate testing.
---
 phpunit.xml.dist                             | 2 +-
 src/Dto/Manifest.php                         | 3 +++
 src/Resources/config/definition/manifest.php | 4 ++++
 src/Twig/PwaRuntime.php                      | 6 +++++-
 tests/autoload.php                           | 9 +++++++++
 5 files changed, 22 insertions(+), 2 deletions(-)
 create mode 100644 tests/autoload.php

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
index feb46b0..3d7f866 100644
--- a/phpunit.xml.dist
+++ b/phpunit.xml.dist
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-        bootstrap="vendor/autoload.php"
+        bootstrap="tests/autoload.php"
         colors="true"
         xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
         cacheDirectory=".phpunit.cache"
diff --git a/src/Dto/Manifest.php b/src/Dto/Manifest.php
index a81f2a9..34abd7c 100644
--- a/src/Dto/Manifest.php
+++ b/src/Dto/Manifest.php
@@ -11,6 +11,9 @@ final class Manifest
 {
     use TranslatableTrait;
 
+    #[SerializedName('use_credentials')]
+    public bool $useCredentials = true;
+
     #[SerializedName('background_color')]
     public null|string $backgroundColor = null;
 
diff --git a/src/Resources/config/definition/manifest.php b/src/Resources/config/definition/manifest.php
index 07cbd8d..b448f49 100644
--- a/src/Resources/config/definition/manifest.php
+++ b/src/Resources/config/definition/manifest.php
@@ -27,6 +27,10 @@
                         ->info('The public URL of the manifest file.')
                         ->example('/site.manifest')
                     ->end()
+                    ->booleanNode('use_credentials')
+                        ->defaultTrue()
+                        ->info('Indicates whether the manifest should be fetched with credentials.')
+                    ->end()
                     ->scalarNode('background_color')
                         ->info(
                             'The background color of the application. It  should match the background-color CSS property in the sites stylesheet for a smooth transition between launching the web application and loading the site\'s content.'
diff --git a/src/Twig/PwaRuntime.php b/src/Twig/PwaRuntime.php
index e55388c..e3ca916 100644
--- a/src/Twig/PwaRuntime.php
+++ b/src/Twig/PwaRuntime.php
@@ -56,8 +56,12 @@ public function load(
     private function injectManifestFile(string $output): string
     {
         $url = $this->assetMapper->getPublicPath($this->manifestPublicUrl) ?? $this->manifestPublicUrl;
+        $useCredentials = '';
+        if ($this->manifest->useCredentials === true) {
+            $useCredentials = ' crossorigin="use-credentials"';
+        }
 
-        return $output . sprintf('%s<link rel="manifest" href="%s">', PHP_EOL, $url);
+        return $output . sprintf('%s<link rel="manifest"%s href="%s">', PHP_EOL, $useCredentials, $url);
     }
 
     private function injectThemeColor(string $output, bool $themeColor): string
diff --git a/tests/autoload.php b/tests/autoload.php
new file mode 100644
index 0000000..552064b
--- /dev/null
+++ b/tests/autoload.php
@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+use Symfony\Component\ErrorHandler\ErrorHandler;
+
+require_once __DIR__ . '/../vendor/autoload.php';
+
+ErrorHandler::register(null, false);