Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pwa:create:sw command puts sw.js file in project root directory #101

Closed
davidromani opened this issue Mar 5, 2024 · 6 comments · Fixed by #103
Closed

pwa:create:sw command puts sw.js file in project root directory #101

davidromani opened this issue Mar 5, 2024 · 6 comments · Fixed by #103

Comments

@davidromani
Copy link
Contributor

davidromani commented Mar 5, 2024

Version(s) affected

1.0.5

Description

I've executed symfony console pwa:create:sw command described here and it created a sw.js file into my project root folder.

How to reproduce

Do the same procedure in described in de description section and you don't get sw.js file located inside assets directory

@tacman
Copy link
Contributor

tacman commented Mar 5, 2024 via email

@Spomky Spomky linked a pull request Mar 5, 2024 that will close this issue
4 tasks
@Spomky
Copy link
Member

Spomky commented Mar 5, 2024

My mistake. I made bad changes. Should be fixed with 1.0.6

@davidromani
Copy link
Contributor Author

Ok, thanks

@Spomky
Copy link
Member

Spomky commented Mar 6, 2024

In the first days of the bundle, this command was a bit more complex.
Now it only creates a copy of an empty file.
I will remove this command and explain you just need to create a file in assets/sw.sj and put your application logic and/or let the bundle populate it with cache rules.

@Spomky
Copy link
Member

Spomky commented Mar 7, 2024

Command removed in 1.1.x

@Spomky Spomky closed this as completed Mar 7, 2024
Copy link

github-actions bot commented Apr 8, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants