Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad screenshot type yaml configuration #171

Closed
davidromani opened this issue Apr 13, 2024 · 2 comments · Fixed by #206
Closed

Bad screenshot type yaml configuration #171

davidromani opened this issue Apr 13, 2024 · 2 comments · Fixed by #206
Assignees
Labels
bug Something isn't working
Milestone

Comments

@davidromani
Copy link
Contributor

davidromani commented Apr 13, 2024

Version(s) affected

1.1.4

Description

Screenshot type config parameter doesn't works.

How to reproduce

pwa:
    manifest:
        enabled: true
        screenshots:
            -
                src: 'screenshots/screenshot-desktop-1.png'
                platform: 'macos'
                label: 'Landing page'
                form_factor: 'wide'
                type: 'image/png'

Possible Solution

It seems that for now only works if you write format instead of type. Fix the related documentation here

@Spomky Spomky self-assigned this Apr 24, 2024
@Spomky Spomky added the bug Something isn't working label Apr 24, 2024
@Spomky Spomky added this to the 1.1.6 milestone Apr 24, 2024
@Spomky Spomky linked a pull request May 25, 2024 that will close this issue
4 tasks
@Spomky
Copy link
Member

Spomky commented May 25, 2024

Thanks.
Documentation is also aligned with this.

@Spomky Spomky closed this as completed May 25, 2024
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants