Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable create:screenshot timeout #233

Open
tacman opened this issue Sep 5, 2024 · 2 comments
Open

configurable create:screenshot timeout #233

tacman opened this issue Sep 5, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@tacman
Copy link
Contributor

tacman commented Sep 5, 2024

Description

My application loads a lot of javascript (datatables, in particular), and the screenshot shows a near empty screen because it's not finished loading.

This is what I'm trying to capture:

https://museado.org/es/pixie/pixie/meili/larco/object

bin/console pwa:create:screenshot https://museado.org/es/pixie/pixie/meili/larco/object --width="1000" --height="700" --filename="tablet/es/pixie_meili_browse-larco_object-1000x700.png

A --timeout 6000 in the CLI might work, or a timeout open in the configuration. What is the default timeout now?

Example

image

but should be

image

@tacman
Copy link
Contributor Author

tacman commented Sep 16, 2024

Any suggestions on how to solve this? Like waiting until a particular element appears?

In this case, it loads datatables and all its plugins, then loads a batch of data including photos, so the initial page load is pretty heavy. Then it works pretty quickly, but I'm not sure how to get a screenshot if the site itself takes several seconds to get to this point.

@Spomky
Copy link
Member

Spomky commented Sep 22, 2024

Hi,

I noted the Panther application has a waitFor method.
It could be interesting to wait for a specific class/id to be present before the screenshot.

@Spomky Spomky self-assigned this Sep 22, 2024
@Spomky Spomky added the enhancement New feature or request label Sep 22, 2024
@Spomky Spomky added this to the 1.3.0 milestone Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants