Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework item damage output calculation #89

Open
NeumimTo opened this issue Dec 13, 2018 · 1 comment
Open

Rework item damage output calculation #89

NeumimTo opened this issue Dec 13, 2018 · 1 comment
Assignees
@NeumimTo
Labels
Common enhancement
Milestone
2.1.0

Comments

@NeumimTo
Copy link
Member

Class Damage = merged damage value from classes/races, either sum, or max
additionally there should be one more configuration option which will cover states where a player has item in hand having additional item attribute generic.damage

  • IGNORE - generic.damage value will be ignored and Class Damage will be prioritized (=current implementation)
  • OVERRIDE - overrides Class damage if present on an itemstack
  • SUM - Class damage + generic.damage
  • MAX - damage = max(Class damage, generic.damage)
@NeumimTo NeumimTo self-assigned this May 28, 2019
@NeumimTo NeumimTo added this to the 2.1.0 milestone May 28, 2019
@NeumimTo
Copy link
Member Author

NeumimTo commented Mar 2, 2020

#137 - random damage ranges

  • On spigot add support for mmo items

@NeumimTo NeumimTo mentioned this issue Mar 2, 2020
Closed
NeumimTo pushed a commit that referenced this issue Mar 6, 2020
initial work on #89
b2d049a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NeumimTo NeumimTo

Labels
Common enhancement
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
1 participant
@NeumimTo