Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft-implemented methods are not 'unmapped' properly #276

Open
Aaron1011 opened this issue Jul 25, 2018 · 1 comment
Open

Soft-implemented methods are not 'unmapped' properly #276

Aaron1011 opened this issue Jul 25, 2018 · 1 comment

Comments

@Aaron1011
Copy link
Contributor

When mixin.env.remapRefMap is enabled (such as when using GradleStart), Mixin allows running an obfuscated Mixin-using jar (e.g. a production SpongeForge jar) in a development environment. However, Mixin currently fails to properly deobfuscate any 'soft-implemented' methods.

In InterfaceInfo#renameMethod, Mixin checks to ensure that the soft-implemented prefixed method is present in the target interface. When running an obfuscated jar in a development environment, this.methods will contain deobfuscated method names, since the target interface will have been run through DeobfuscatedTransformer. However, the prefixed method in the Mixin class will still be obfuscated, since a prefixed method won't match any SRGs when the Mixin class bytes are loaded.

@Mumfrey
Copy link
Member

Mumfrey commented Jul 26, 2018

Ah ok. Will look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants