Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Larger scale examples #690

Open
parlough opened this issue May 8, 2018 · 6 comments
Open

Larger scale examples #690

parlough opened this issue May 8, 2018 · 6 comments
Labels
FLARD This is gathering dust input wanted We would like to hear your opinion low priority Small issues like typos that don't have much of an impact

Comments

@parlough
Copy link
Contributor

parlough commented May 8, 2018

At the moment, we have small samples throughout the documentation, and we have some commonly outdated larger samples in the Cookbook repository. I am pondering adding a new section under the Creating a plugin category with pages about larger scale samples, with some information on the docs, maybe some code snippets, and links to the full projects.

If this comes to fruition, I hope it replaces Cookbook and acts as a great place for new developers to see updated, large scale examples, with more in-depth documentation on their individual purposes and their methods of doing so.

I am considering either creating each one as its own repository in a new organization, but I would also be open to creating a new mono-repo in the SpongePowered organization. Either way I need a name similar to Cookbook but more Sponge specific that somehow relates to plugin samples. I have a feeling Inscrutable can come up with something good here.

To help guarantee these plugins are kept up to date, it is a possibility we could include them as a Git submodule in Spongecommon as the test suite.

Note: I am not sure on the timeline for this, but due to its larger scale(and the fact SpongeAPI will change a lot soon) it is fairly low priority compared to other issues and Sponge implementation work at the moment.

@parlough parlough added the FLARD This is gathering dust label May 8, 2018
@gabizou
Copy link
Member

gabizou commented May 8, 2018

Ideally, the larger scale plugins would be provided from SpongeCommon/testplugins since those are required to compile and well... work. Since they're used for testing and proving something is working, I think it should be responsible for wooing some more advanced plugin examples.

@parlough
Copy link
Contributor Author

parlough commented May 8, 2018

@gabizou I would like to keep the plugins in their own repository, as they are more specific to the API(and can be used on other implementations), and I want to be able to work on them without opening up all of Sponge. They are easier to view for others that way as well(which is the intention of these samples). I would be happy to include them as a Git submodule though inside of SpongeCommon. How does that sound?

I planned to flesh out testplugins more anyway, so I guess this kills two birds with one stone.

@gabizou
Copy link
Member

gabizou commented May 8, 2018

I'd be ok with that. Let me know what you want the repository named (or we could just destroy the cookbook plugin repo and rewrite it with the test plugins). One issue could be for the plugins themselves having the dependency on spongeapi from the parent gradle files wouldn't quite work out without importing spongecommon.

@Inscrutable Inscrutable added input wanted We would like to hear your opinion low priority Small issues like typos that don't have much of an impact labels May 9, 2018
@Inscrutable
Copy link
Member

Substituting the existing CookBook would be acceptable, as it's often out-of-date, but might lead to confusion. A new repo would be better. Some name suggestions: The Sideboard, Sink, SqueegeeFarm, Blotter, SpongeToolBox, AbsorBook, SplatKit, SpongeGallery, the Galley, HomeSponge, Saturator, SpongeKaboodle, Infusion Pool, Reservoir, Lake Spongie, The Sea of Sponge, Soakbox, Spongy Skeletons, Porous Templates, The Wringer, Spongie's SandBox, Sliced Sponge ....

@parlough
Copy link
Contributor Author

parlough commented May 9, 2018

I was waiting for your name suggestions ❤️

I'm not sure which I like best just yet...but I'll sleep on it.


In relation to the Gradle requirements for SpongeCommon, we can probably work some Gradle magic in overriding their SpongeAPI dependency to be the API submodule when loaded in. Might need some help on that once I get to that point, but we can figure something out.

@Grauldon
Copy link
Contributor

How about these for name suggestions:

SpongeSamples
SpongeXamples
SpongeModels
SpongeNstance (as in Sponge instance)
SpongeUstrate (as in Sponge illustration)
SpongeOnstration (as in demonstration)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FLARD This is gathering dust input wanted We would like to hear your opinion low priority Small issues like typos that don't have much of an impact
Projects
None yet
Development

No branches or pull requests

4 participants