update source/plugin/project/gradle to api-8 #888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dualspiral
reviewed
Jan 12, 2022
dualspiral
reviewed
Jan 12, 2022
Inscrutable
approved these changes
Jan 14, 2022
ImMorpheus
force-pushed
the
api8/gradle
branch
from
cc9b257 to
dc6a5ff
Compare
ImMorpheus
force-pushed
the
api8/gradle
branch
from
dc6a5ff to
cf778d7
Compare
zml2008
reviewed
Feb 7, 2022
|
|
||
| plugins { | ||
| id 'java' | ||
| id 'org.spongepowered.plugin' version '0.11.3' | ||
| r"""`java-library` |
zml2008
requested changes
Feb 7, 2022
| @@ -114,18 +120,17 @@ Without SpongeGradle | |||
| Generally, everything necessary to compile a Sponge plugin using Gradle can be done by simply adding the SpongeAPI | |||
| dependency to your project: | |||
There was a problem hiding this comment.
This is not as true anymore -- you'd have to manually write out a metadata file
There was a problem hiding this comment.
Co-authored-by: zml <[email protected]>
|
Bump Bump. @ImMorpheus can you resolve the last few bits? I'd love to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimal example is based on https://github.com/SpongePowered/sponge-plugin-template/blob/api-8/build.gradle.kts
Fix #877