Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate upload to crates.io #462

Closed
infinity0 opened this issue Dec 24, 2019 · 6 comments
Closed

automate upload to crates.io #462

infinity0 opened this issue Dec 24, 2019 · 6 comments
Assignees
Labels
ci CI related issues or improvements enhancement A new feature that would improve Spotifyd wontfix Issues that will not be fixed under any circumstances
Milestone

Comments

@infinity0
Copy link

infinity0 commented Dec 24, 2019

Hi, please upload this to crates.io - we need this in order to package it for Debian

Automate the upload as well.

@infinity0 infinity0 added the bug A functionality or parts of a program that do not work as intended label Dec 24, 2019
@mainrs mainrs added enhancement A new feature that would improve Spotifyd ci CI related issues or improvements and removed bug A functionality or parts of a program that do not work as intended labels Dec 24, 2019
@SimonTeixidor
Copy link
Member

Hi! I've wanted to do this for a long time, but we had dependencies that were not yet on crates.io which blocked it. That doesn't seem to be an issue any more. I've updated our git dependencies to use crates.io dependencies, and made a release here: https://crates.io/crates/spotifyd.

Tell me if there is anything else we need to do in order for you to package spotifyd, it would be really helpful for our users!

@mainrs
Copy link
Member

mainrs commented Jan 11, 2020

Is it possible that I can upload to crates as well? Or can github maintainers upload there too?

@infinity0
Copy link
Author

Awesome, thanks a lot! In general keeping your dependencies up-to-date also makes packaging easier for us, as we then don't have to maintain old versions of crates. There is a tool, cargo-outdated that can help with that.

@mainrs
Copy link
Member

mainrs commented Jan 12, 2020

We have an integration in the repo (dependabot) but the current open PRs from it involve some refactoring (some are just import changes). The dbus related ones actually involve re-writing dbus_mpris.rs again, not all of it though. The ones that pass the CI pipeline are usually updated.

@mainrs mainrs changed the title upload to crates.io automate upload to crates.io Jan 24, 2020
@mainrs mainrs self-assigned this Jan 24, 2020
@mainrs
Copy link
Member

mainrs commented Jan 25, 2020

@stale
Copy link

stale bot commented Apr 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issues that will not be fixed under any circumstances label Apr 16, 2021
@stale stale bot closed this as completed Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI related issues or improvements enhancement A new feature that would improve Spotifyd wontfix Issues that will not be fixed under any circumstances
Projects
None yet
Development

No branches or pull requests

4 participants