Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Image Generation Service #529

Open
ItsMeBrianD opened this issue Apr 8, 2024 · 0 comments
Open

Import Image Generation Service #529

ItsMeBrianD opened this issue Apr 8, 2024 · 0 comments

Comments

@ItsMeBrianD
Copy link
Member

ItsMeBrianD commented Apr 8, 2024

Sprocket V1 uses an SVG-based image generation service to dynamically render images like report cards without needing to edit the actual image, but rather just the text.

We should copy as much of the service as possible into v2, with the following caveats:

  • The image generation UI should not be ported for this issue; we should integrate it into the Sprocket main UI, rather than running it separately.

  • The Service Connector that lives in v1/common should be moved into the Image Gen Service's directory, similarly to the way Matchmaking is set up in v2. This colocation of service and connector better represents where the responsibility for the connector lies, and prevents lib from becoming bloated with service-specific code.

  • There may be a better way to handle the saving of image types, as the single row in the database JSON blob got quite bloated. We also do not want to connect any services other than core to the primary database if possible, and image types are very slow moving. We could consider ripping them out of the database and simply loading them from a file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant