Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reification options passed as a parameter to Configs.Reify are not correctly passed through types with FromDoc's #48

Open
grahamboree opened this issue Feb 25, 2023 · 0 comments
Assignees
Labels
🐛bug Clearly not working as expected

Comments

@grahamboree
Copy link
Contributor

Calling Configs.Reify<T> with ReificationOptions flags should override the default reification options for the object graph that it's reading. This is true when reading normal data, but if any type in the graph has a FromDoc, that type and all children of that object graph will not use the provided reification options.

This may require updating FromDoc signatures to take reification options, or we could add another static field to track this.

@grahamboree grahamboree added the 🐛bug Clearly not working as expected label Feb 25, 2023
@grahamboree grahamboree self-assigned this Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Clearly not working as expected
Projects
None yet
Development

No branches or pull requests

1 participant