🔨 Attempt to fix building issues on MacOS

See #1143
SpyglassMC · May 19, 2024 · 7b833fb · 7b833fb
1 parent 42dbc01
commit 7b833fb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/playground/esbuild.js b/packages/playground/esbuild.js
@@ -16,7 +16,10 @@ try {
 		platform: 'node',
 		target: ['firefox89', 'chrome93'],
 		bundle: true,
-		external: ['electron', 'vscode'],
+		// fsevents is a MacOS specific native extension used by chokidar for file
+		// watching and should not be bundled:
+		// https://github.com/SpyglassMC/Spyglass/issues/1143
+		external: ['electron', 'fsevents', 'vscode'],
 		sourcemap: isDev,
 		minify: !isDev,
 	})

diff --git a/packages/vscode-extension/esbuild.mjs b/packages/vscode-extension/esbuild.mjs
@@ -17,7 +17,10 @@ try {
 		target: 'node16.13',
 		bundle: true,
 		outdir: './dist',
-		external: ['electron', 'vscode'],
+		// fsevents is a MacOS specific native extension used by chokidar for file
+		// watching and should not be bundled:
+		// https://github.com/SpyglassMC/Spyglass/issues/1143
+		external: ['electron', 'fsevents', 'vscode'],
 		sourcemap: isDev,
 		minify: !isDev,
 	})