Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getEntityFromItem in mcdoc contexts #1554

Open
naren932 opened this issue Jul 31, 2024 · 1 comment
Open

Implement getEntityFromItem in mcdoc contexts #1554

naren932 opened this issue Jul 31, 2024 · 1 comment
Labels
✨ feature New feature or request /mcdoc
Milestone

Comments

@naren932
Copy link

image

i have an EntityTag an some stuff on it to make an item frame invisible and silent, but spyglass says that an EntityTag needs a "id" key?
the command runs fine on minecraft but the error just bugs me

(i have an issue similar like this with spyglassmc doesnt recognize "EntityTag", but it was changed to this issue. but this is not a repost)
also is there a way to just ignore the error and hide them to make me not rage?

Code:
give @s item_frame{EntityTag:{Silent:1b,Tags:["crafting_bench"],Item:{id:"minecraft:item_frame",Count:1b,tag:{CustomModelData:1000}},Invulnerable:1b,Invisible:1b,Fixed:1b},display:{Name:'{"text":"Crafting Bench","italic":false}'},CustomModelData:1000} 1

Minecraft Version: 1.18.2
SpyglassMC Version: v4.1.2

@MulverineX MulverineX changed the title Missing key "id" inside an EntityTag Implement getEntityFromItem in mcdoc contexts Jul 31, 2024
@MulverineX MulverineX added ✨ feature New feature or request /mcdoc labels Jul 31, 2024
@MulverineX
Copy link
Member

id will be made optional soon, that's a bug in vanilla-mcdoc, thanks for the report. To properly fix this though, we need to implement the implicit entity type context for spawnable items.

@misode misode added this to the Backlog milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New feature or request /mcdoc
Projects
None yet
Development

No branches or pull requests

3 participants