Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bracken 3.1 #1252

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add bracken 3.1 #1252

wants to merge 3 commits into from

Conversation

Kincekara
Copy link
Collaborator

Closes #1251
There is no significant change. I changed the bracken_ver 2.9 into 3.1. The rest of them are mostly cosmetic changes to increase readability.

diff ./build-files/bracken/2.9/Dockerfile ./build-files/bracken/3.1/Dockerfile
2c2
< ARG BRACKEN_VER="2.9"
---
> ARG BRACKEN_VER="3.1"
5c5
< FROM ubuntu:jammy as builder
---
> FROM ubuntu:jammy AS builder
10c10,14
< RUN apt-get update && apt-get install -y build-essential perl wget zlib1g-dev
---
> RUN apt-get update && apt-get install -y \
>     build-essential \
>     perl \
>     wget \
>     zlib1g-dev
13c17
< RUN wget https://github.com/DerrickWood/kraken2/archive/refs/tags/v${KRAKEN_VER}.tar.gz &&\
---
> RUN wget -q https://github.com/DerrickWood/kraken2/archive/refs/tags/v${KRAKEN_VER}.tar.gz &&\
18c22
< RUN wget https://github.com/jenniferlu717/Bracken/archive/refs/tags/v${BRACKEN_VER}.tar.gz &&\
---
> RUN wget -q https://github.com/jenniferlu717/Bracken/archive/refs/tags/v${BRACKEN_VER}.tar.gz &&\
24c28
< FROM ubuntu:jammy as app
---
> FROM ubuntu:jammy AS app
38,39c42,47
< RUN apt-get update && apt-get install --no-install-recommends -y perl python-is-python3 libgomp1 pigz \
< && rm -rf /var/lib/apt/lists/* && apt-get autoclean
---
> RUN apt-get update && apt-get install --no-install-recommends -y \
>     perl \
>     python-is-python3 \
>     libgomp1 \
>     pigz &&\
>     rm -rf /var/lib/apt/lists/* && apt-get autoclean
44,45c52,53
< ENV LC_ALL=C
< ENV PATH="${PATH}:/kraken2:/Bracken"
---
> ENV PATH="${PATH}:/kraken2:/Bracken" \
>     LC_ALL=C
52c60
< FROM app as test
---
> FROM app AS test
54c62
< RUN apt-get update && apt-get install --no-install-recommends -y wget
---
> RUN apt-get update && apt-get install -y wget
57c65
< RUN wget --no-check-certificate https://genome-idx.s3.amazonaws.com/kraken/k2_viral_20231009.tar.gz && \
---
> RUN wget -q https://genome-idx.s3.amazonaws.com/kraken/k2_viral_20231009.tar.gz && \
61c69
< RUN wget --no-check-certificate https://github.com/StaPH-B/docker-builds/raw/83ee344304794f4ffa162d1c082bb35f916badcf/tests/SARS-CoV-2/SRR13957123_1.fastq.gz \
---
> RUN wget -q https://github.com/StaPH-B/docker-builds/raw/83ee344304794f4ffa162d1c082bb35f916badcf/tests/SARS-CoV-2/SRR13957123_1.fastq.gz \
66c74
< RUN bracken -d ./db -i k2_report.txt -o bracken_report.txt -r 75 -l S -t 10 && \
---
> RUN bracken -d ./db -i k2_report.txt -o bracken_report.txt -r 75 -l S -t 10 &&\

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number in build-files (i.e. docker-builds/build-files/spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. build-files/shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. docker-builds/build-files/spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request An Update]: Bracken 3.1
1 participant