Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockquote formatting is broken #95

Open
alexwlchan opened this issue Jul 4, 2015 · 6 comments
Open

Blockquote formatting is broken #95

alexwlchan opened this issue Jul 4, 2015 · 6 comments

Comments

@alexwlchan
Copy link
Contributor

For example:

screen shot 2015-07-04 at 14 45 54

screen shot 2015-07-04 at 14 46 13

In the source files, all these blockquotes have an opening <blockquote> tag, but all the inline formatting is in Markdown. It’s skipped by the Markdown parser, so the formatting comes out raw.

I would put in a pull request for this, but it’s ~180 posts and I don’t really have time to do that right now.

@JonHMChan
Copy link
Contributor

This is a known issue. The import we used didn't parse blockquotes correctly, and we decided to simply manually repair those posts with high traffic or recently added for the launch. Otherwise, it's been treated as an acceptable trade-off.

It'll simply require slowly fixing those formatting errors one at a time.

@alexwlchan alexwlchan changed the title Blockquote formatting is all kinds of wrong Blockquote formatting is broken Jul 4, 2015
@alexwlchan
Copy link
Contributor Author

I’ve had a look through a few dozen of the posts, and I’ve tried a very simple heuristic to see if I can fix it in one fell swoop. I’m just building the site – I’ll open a pull request if I think I can make a useful improvement.

@JonHMChan I already had some of the work done; I just wanted to be sure there wasn’t an easy fix in your auto cleanup scripts before I dived into it. :-)

@alexwlchan
Copy link
Contributor Author

@JonHMChan I think my method gives a pretty reliable way of fixing the broken blockquotes, yay. I’m just inspected the generated posts by hand to make sure it hasn’t done anything really silly. It’s also flushing out a bunch of other small formatting errors, which I’ll fix.

But this change touches nearly 200 posts. Would you prefer the change to show up in a single monolithic commit, or for me to break it up into smaller commits? If the latter, how should I break it up?

@JonHMChan
Copy link
Contributor

@alexwlchan One major commit is fine.

@shu8
Copy link
Contributor

shu8 commented Jul 12, 2015

If we want to help, do we just change the markdown in blockquotes to proper HTML tags? @JonHMChan

@alexwlchan
Copy link
Contributor Author

@shu8 Actually, I think I might have fixed most of them already. (It was a couple of PRs ago, but I forgot to update the issue.) Mostly hand-inspecting the broken posts, and modifying as appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants