Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: git branch per kubernetes version #18

Open
AndyMoore opened this issue Oct 23, 2017 · 2 comments
Open

proposal: git branch per kubernetes version #18

AndyMoore opened this issue Oct 23, 2017 · 2 comments

Comments

@AndyMoore
Copy link
Contributor

in order to differentiate between the variation in the apis of different kubernetes versions i propose to create a branch per kubernetes version

These would then be used in a pack install as

st2 pack install stackstorm-kubernetes=v1.5.7

Upside is being able to cover all versions of the api

Downside is versioning - where a bug is found and new packs must be generated do the versions get overwritten? or do we use v1.5.7-2 (or similar)?

these could then be merged into the the 'main branch', however this is a fair amount of admin for every change.. (could be scripted of course)

@emptywee
Copy link

I don't think API changes within one minor branch, e.g. thought all 1.6.x or 1.5.x versions of kubernetes. It'll probably make sense to have a branch for 1.5, 1.6, 1.7, 1.8 and so forth.

@AndyMoore111
Copy link
Contributor

ye that's a good shout too. also easier to manage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants