Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change mapping-library and improve map layout #29

Closed
koilebeit opened this issue Nov 2, 2023 · 1 comment
Closed

feat: change mapping-library and improve map layout #29

koilebeit opened this issue Nov 2, 2023 · 1 comment
Assignees
@koilebeit
Labels
enhancement New feature or request

Comments

@koilebeit
Copy link
Contributor

koilebeit commented Nov 2, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

  • Svelte-maplibre, which is currently used for the map, is still very rudimentary at the moment.
  • Sometimes the labels on the map overlap. This happens because there are a few locations that are very close together:

Image

Describe the solution you'd like

  • Maplibre-gl can be used directly, so that the full range of functions can be used. At the same time, the map layout can be improved.

  • The clusters should be improved and it should be considered if instead of the big "text markers", symbols + a label should be used:

Image

Describe alternatives you've considered
Keep svelte-maplibre

Additional context
-
@koilebeit koilebeit self-assigned this Nov 2, 2023
@maehr
Copy link
Member

maehr commented Nov 3, 2023

@koilebeit Thanks for the issue. The images are not visible, can you please reupload them?

@maehr maehr added the enhancement New feature or request label Nov 3, 2023
@koilebeit koilebeit mentioned this issue Feb 2, 2024
Merged
7 tasks
maehr added a commit that referenced this issue Feb 13, 2024
@koilebeit @maehr
change maplibre library and improve map layout #29 (#69)
f120fa4 
* wip

* fixed typo

* fix dependencies; formatting

* add error-handling

* correct comments, change img location, etc.

* refactor code

* Revert "refactor code"

This reverts commit 20c884a.

* refractor again

* update package.json

* format files

* fix bug (map height) and error (lint)

---------

Co-authored-by: Moritz Mähr <[email protected]>
@maehr maehr closed this as completed Feb 13, 2024
maehr added a commit that referenced this issue Feb 13, 2024
@maehr
Revert "change maplibre library and improve map layout #29 (#69)"
9201827 
This reverts commit f120fa4.
maehr added a commit that referenced this issue Feb 13, 2024
@maehr
Revert "change maplibre library and improve map layout #29 (#69)" (#79)
1b4d157 
This reverts commit f120fa4.
@coderabbitai coderabbitai bot mentioned this issue Feb 26, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koilebeit koilebeit

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maehr @koilebeit