Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support required flag for group items #55

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ZardenSawtooth
Copy link

Support required flag for group items

♻️ Current situation & Problem

Relates to this issue where the required flag for the Group item couldn't be changed using the survey builder.

⚙️ Release Notes

  • Group items now allow the required field to be toggled, similar to other types such as the text field as described in this issue.

✅ Testing

image

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@ZardenSawtooth ZardenSawtooth marked this pull request as ready for review August 21, 2024 18:17
@vishnuravi vishnuravi self-requested a review August 23, 2024 12:01
Copy link
Member

@vishnuravi vishnuravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toggling the required flag on after this change appears to be leading to a validation error.

Screenshot 2024-08-23 at 11 17 48 AM

@vishnuravi
Copy link
Member

vishnuravi commented Aug 23, 2024

Once the validation error is addressed, I would recommend creating a survey with this flag enabled and testing it with ResearchKitOnFHIR and/or SpeziQuestionnaire to ensure that the JSON works as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants