Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realm: Suppress NUMA detection warning when using the programmatic configuration API #1834

Open
manopapad opened this issue Feb 21, 2025 · 4 comments
Assignees

Comments

@manopapad
Copy link
Contributor

The programmatic configuration API already signifies failure to detect NUMA resources through return values, that the calling code is supposed to inspect. Therefore, when using the programmatic API, we shouldn't be emitting warnings like:

[0 - 7fca1b871b80]    0.000000 {5}{module_config}: Module numa can not detect resources.

when NUMA detection fails.

@eddy16112
Copy link
Contributor

When calling bool ModuleConfig::get_resource(const std::string name, T &value), do we care about why it returns false? Currently, there are two cases that could return a false, one is module fails to detect resources, the other is name is not a valid one. If we want to know the reason of returning false, the best option is to replace bool with RealmStatus, which is an error code.

@manopapad
Copy link
Contributor Author

Agreed

@eddy16112
Copy link
Contributor

@manopapad Do you mind if we change the type signature of bool ModuleConfig::get_resource(...) into RealmStatus ModuleConfig::get_resource(...) ?

@manopapad
Copy link
Contributor Author

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants