Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete Concurrency Checking #54

Open
1 task done
PSchmiedmayer opened this issue Mar 29, 2024 · 5 comments · May be fixed by #85
Open
1 task done

Complete Concurrency Checking #54

PSchmiedmayer opened this issue Mar 29, 2024 · 5 comments · May be fixed by #85
Assignees
@jdisho
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@PSchmiedmayer
Copy link
Member

Problem

With Swift 6 approaching in a few months and nightly builds already being available we should ensure that all our packages are working well with all Swift concurrency checks.

Solution

Enable strict concurrency checking in the Swift Package in a PR and ensure that we don't have any warnings remaining in the packages as we develop new features or fix bugs from now.

The UI Testing App target should also enable Enable strict concurrency checking.

The corresponding PR should fix all related warnings when enabling strict concurrency checking.

Additional context

We should consider adding SWIFT_TREAT_WARNINGS_AS_ERRORS = YES to our general workflows to ensure all warnings are flagged as errors during our CI setup.

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@PSchmiedmayer PSchmiedmayer added enhancement New feature or request help wanted Extra attention is needed labels Mar 29, 2024
@PSchmiedmayer PSchmiedmayer mentioned this issue Mar 29, 2024
Open
24 tasks
@jdisho
Copy link
Collaborator

jdisho commented Dec 18, 2024

I can't assign this issue to myself, but I'm on it 😊

cc: @LeonNissen @philippzagar

@philippzagar
Copy link
Member

philippzagar commented Dec 18, 2024 •
edited
Loading

I can't assign this issue to myself, but I'm on it 😊

cc: @LeonNissen @philippzagar

Thanks @jdisho for taking initiative here, greatly appreciated! Let me know if you need any input or support from my side! 🚀
Might make sense to wait until #64 is merged, as it will funamentally rewamp the OpenAI layer. Still, you could start working on the core SpeziLLM target and the Local/Fog layers.

Fyi: You now have Triage permissions on this repo, so you can assign issues to yourself! 🎉

@jdisho
Copy link
Collaborator

jdisho commented Dec 19, 2024

Thank you 🤩 - @philippzagar

@jdisho
Copy link
Collaborator

jdisho commented Dec 20, 2024

@philippzagar - Seems like I have only read access. I can't push anything.

@philippzagar
Copy link
Member

@jdisho Done! You should be able to create branches on the repo now!

@jdisho jdisho linked a pull request Dec 20, 2024 that will close this issue
Draft
1 task
@PSchmiedmayer PSchmiedmayer linked a pull request Jan 20, 2025 that will close this issue
Swift 6 Complete Concurrency Checking #85
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdisho jdisho

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Project Planning
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Swift 6 Complete Concurrency Checking StanfordSpezi/SpeziLLM
3 participants
@jdisho @philippzagar @PSchmiedmayer