Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to decompiler to allow auto-commit function param/returns #11

Open
Escapingbug opened this issue May 27, 2021 · 0 comments
Labels
difficulty: medium requires some internal insights of the project itself
Milestone

Comments

@Escapingbug
Copy link

Currently when analyzing, the function params and return values analyzed are not stored in database by default.
So whenever decompile a function, its called function params are analyzed out of the view of the caller. This is not the way IDA handles it and gives an illusion that its param analysis failed since the caller's view of the function and the callee's view of the function signature are inconsistent.

An example to illustrate this:

image

This one above is what caller thinks test_function should look like.
But if we take a look at the callee test_function itself:

image

It actually thinks it has only one parameter. This looks a lot like they are inconsistent.

However, this is just a mechanism since the params are not applied to the database.

If we do:
image

Then everything would be fine now:
image

We should add an option of automatically do this when doing basic analysis (if I'm not mis-remembered, when doing auto analysis, a basic decompiling is performed to most functions), they should be automatically commited. so we get a consistent view.

@Escapingbug Escapingbug added the difficulty: medium requires some internal insights of the project itself label May 27, 2021
@Escapingbug Escapingbug added this to the first release milestone May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium requires some internal insights of the project itself
Projects
None yet
Development

No branches or pull requests

1 participant