Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up missed add minus values in decompiled result #29

Open
Escapingbug opened this issue Jul 3, 2021 · 0 comments
Open

Clean up missed add minus values in decompiled result #29

Escapingbug opened this issue Jul 3, 2021 · 0 comments
Labels
bug Something isn't working difficulty: medium requires some internal insights of the project itself Upstream This issue also applies to upstream ghidra. When solving, we should better care about them.

Comments

@Escapingbug
Copy link

Describe the bug
The binary add should not be applied to minus value. If so, we should use sub to get a cleaner result.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
The binary add should not be applied to minus value. If so, we should use sub to get a cleaner result.

Screenshots
image
This should not happen.

Attachments
If applicable, please attach any files that caused problems or log files generated by the software.

Environment (please complete the following information):

  • OS: [e.g. macOS 10.14.2]
  • Java Version: [e.g. 11.0]
  • Ghidra Version: [e.g. 9.1.2]
  • Ghidra Origin: [e.g. official ghidra-sre.org distro, third party distro, locally built]

Additional context
Add any other context about the problem here.

@Escapingbug Escapingbug added bug Something isn't working difficulty: medium requires some internal insights of the project itself Upstream This issue also applies to upstream ghidra. When solving, we should better care about them. labels Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working difficulty: medium requires some internal insights of the project itself Upstream This issue also applies to upstream ghidra. When solving, we should better care about them.
Projects
None yet
Development

No branches or pull requests

1 participant