Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Auto Translate needs 3 arguments to update #99

Open
djpadbit opened this issue Dec 31, 2020 · 1 comment
Open

[Bug] Auto Translate needs 3 arguments to update #99

djpadbit opened this issue Dec 31, 2020 · 1 comment
Labels
fixed in dev bugs that got fixed, but aren't in a public (curseforge) release yet

Comments

@djpadbit
Copy link

Describe the bug
When updating the Auto Translate modifier, it needs 3 arguments despite it only using 2. I think it's just a copy and paste leftover here :

@Callback(doc = "function(Double:x, Double:y, Double:z):boolean -- sets new values", direct = true)
public Object[] set(Context context, Arguments args){
if(!args.isDouble(0) || !args.isDouble(1) || !args.isDouble(2))
return new Object[]{ false, "3 values(Double) required! x,y,z" };

In which environment did the Bug appear?
Singleplayer, Forge server

To Reproduce
Steps to reproduce the behavior:

  1. In the lua interpreter, type in the code snippet below

Expected behavior
It should update the modifier with 2 arguments.

Screenshots / Code Snippet

g = component.glasses
g.removeAll()
t = g.addText2D()
t.addAutoTranslation(10,10)
t.updateModifier(1,20,20) -- This works
m = t.modifiers()[1]
m.set(20,20) -- This should work but doesn't
m.set(20,20,0) -- This does work

Minecraft:

  • Mod Version: OpenGlasses-MC1.12.2-2.2-53
  • Minecraft Version: 1.12.2
  • Forge Version: 14.23.5.2854

Additional context

  • OpenComputers Version: 1.7.5.192
@ben-mkiv
Copy link
Collaborator

Thank you, indeed some copypasta issue here...

I'll leave the bug open until i published a official version on CurseForge

@ben-mkiv ben-mkiv reopened this Dec 31, 2020
@ben-mkiv ben-mkiv added the fixed in dev bugs that got fixed, but aren't in a public (curseforge) release yet label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in dev bugs that got fixed, but aren't in a public (curseforge) release yet
Projects
None yet
Development

No branches or pull requests

2 participants