Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Lore Shift: Nian #5

Open
lectronyx opened this issue Dec 12, 2023 · 0 comments
Open

[FEATURE] Lore Shift: Nian #5

lectronyx opened this issue Dec 12, 2023 · 0 comments

Comments

@lectronyx
Copy link
Contributor

Name of feature:

Lore Shift: Nian

Related Pull Request on other codebase:

N/A

Additional Info:

Rename Moths to Nian
Write Nian Lore
Apply Nian Lore through items, cultural foods, and the moth description in the character setup.

blinkdog pushed a commit that referenced this issue Jan 5, 2025
…emap Expansion #5 (#3627)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
This removes a substantial amount of bullshit from atmospherics, like
the 3 made up gases that only served for powergaming purposes.

This PR instead replaces them with much more fitting IRL gases seen in
irl planets such as:
- Argon
- Carbon Monoxide
- Sulfur Dioxide
- Ammonia
- Metane
- Ozone

Argon in particular inherits the fire suppression behavior from noble
gas, HOWEVER, the threshold to stop reactions has been increased from 10
mols to 75 mols. this should pose an suffocation hazard

The values to atmos fires have been tweaked, some gases that had no
entaphy now have it

This PR also adds a very basic chemical odor system, to detect certain
gases based on smell, in case you don't have an atmos analyzer on you,
and also to get you to actually siphon trace amounts of gases because
they stink up the place in case of a breach

## Why It's Good For The Game

removes cruft, replaces it with actual, fun, non-powergamey stuff that
will be used soon:tm: and also has the potential to have a bunch of fun
and realistic interactions when someone more familiar with this stuff
than me codes it. For example outside of planetary gases, some ideas I
had were:
- Sparks creating ozone
- Ammonia and chlorine mixing creating "snow" (Ammonium chloride) so a
leak of both gases would cover the floor with snow, this sounds like a
fun reaction to scare the shit out of people
- smarter people like @Thera-Pissed would probably know more what to do

## Changelog

:cl:
add: You can now detect certain gases from smell, most notably plasma
add: Adds 6 new gases, all unused at the moment
del: 3 gases, Pluox, Nitryl, and Stimming
balance: The noble gas suppresssion threshold has been increased from 10
mols to 75 mols
balance: Various gases have had their enthalpy (energy released during
fires) adjusted, changing the behavior of gas fires slightly.
balance: Plasma is a much more potent skin/eye irritant
balance: Hydrogen gas is no longer visible
fix: Freon's stage one breath effects should work now, before they were
tied to nitryl's amount
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: retlaw34 <[email protected]>
Co-authored-by: Erika Fox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant