Fix #include Ordering in .dme #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR fixes the include ordering in
shiptest.dmeso we have canonical DreamMaker ordering.This PR is a companion to PR #83 ; part two, where we use the check to fix the problem.
The check itself was also fixed up a bit, to handle case-insensitivity on Windows paths, and a DreamMaker edge case where
.dmffiles are sorted to the end.Why It's Good For The Game
After this PR is merged, people will be able to download a ZIP from GitHub and build it locally.
They can run private servers locally and learn the game.
They can also start coding / mapping / making sprites.