-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
required variables list handling #10
Comments
This is now started. There are other variables that could be created on the fly (like time) but the basics are there. The more serious issue is related to required variables and summarised data objects. |
Hi: As indicated the R and RStudio build tools expect that the I have not pushed the changes to the master branch as I do -William Hughes |
I think the creation of variables should be done by is_present and not getvname, as I wrote before. The required variables list passed to get_climate_data_objects is used in is_present (see attached) and is_present has no way of creating variables. So unless I'm missing something, I think currently a data frame not containing month, for example, will be skipped by get_climate_data_objects. I therefore think is_present should be able to create variables. getvname could then be edited so that the create variable is passed though to is_present and the creation of variables happens in is_present only. |
Edit getvname so that required variables list can contain variables such as month, year, season etc. and getvname will create them, instead of not using the data. We could have a Boolean argument "create" which tells getvname whether it should create the requested variable, if it is not there.
The text was updated successfully, but these errors were encountered: