Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Instrument Request: Concertina (and maybe accordion) #14

Open
theDerpu opened this issue Oct 24, 2024 · 4 comments
Open

New Instrument Request: Concertina (and maybe accordion) #14

theDerpu opened this issue Oct 24, 2024 · 4 comments
Labels
instrument request Request an addition of a new instrument

Comments

@theDerpu
Copy link

theDerpu commented Oct 24, 2024

Why this instrument should be added:

I play the concertina (in english layout, though this isn't too important, anglo may be similar to the layout ingame), thought it would be really simple since it uses a button layout similar to the look of the one provided in game, then accordion came as a second thought since it's also quite similar, but isn't my cup of tea.

  • Interface Type: Grid
    Grid dimensions: Default (7x3)

Note layout: Default (C, D, E, F, G, A, B)

  • Note theme (RGB): a dark red maybe? something like (100, 25, 50)

Audio Files:
Not sure what format is needed? I can record concertina sounds on my own but not sure how it'll sound on my phone, I have a sound font of an accordion however that may come in handy (and sounds similar to a concertina regardless, and frankly I just use it for all my sheet music of concertina's and no one's spotted otherwise)

accor-_I_mean_concertina_soundfont.zip

Concertina Screenshots from google since they're quite rare ;u;
image
^ note the button pattern on the 1st and 3rd image, these are quite common and may be a good reference if you go through with it, (1st is anglo, 2nd is english, anglo may fit better for the mod :3)

@theDerpu theDerpu added the instrument request Request an addition of a new instrument label Oct 24, 2024
@StavWasPlayZ
Copy link
Owner

Thank you so much for your suggestion!

This seems really cool, and I'll definitely be adding this to the instruments idea bank!

Could I just ask you for the source of the soundfont you provided?
I just don't want to have licensing or miscredit issues and such.. :P

I can record concertina sounds on my own but not sure how it'll sound on my phone

It actually very much is possible - I'll just have to do a bunch of sound editing 😅

If you really do want to commit to recording 21 audio tracks, then that would indeed suffice - but let that be a last resort :)

@theDerpu
Copy link
Author

theDerpu commented Oct 25, 2024

Haha oh yea of course licensing probably would be an issue oops,
I can record some if you can say what I need to record haha, if its just loop sounds (I'm supposing, as its the same sound for attack and release since its just one tone) I can just record an mp3 of me going through each note and then I split them up?

@StavWasPlayZ
Copy link
Owner

StavWasPlayZ commented Oct 27, 2024

Well, if I will deem the audio quality sufficient enough, I believe that can work out fantastically!

You basically just need to record yourself playing 21 notes - low C to high B.
I'll attach here tmr or so a sound sample of how I recorded the Nightwind Horn from Genshin, just to demonstrate how that's supposed to be done. But the recording itself is generally no longer than about 3 minutes.

Do keep in mind though that I'm in a bit of a break from this project because of burnout and studies and whatnot - so the task of adding an instrument will generally be delayed in the span of a few months, I believe.

Leave the task of splitting and such for me.

And again - thanks!

@theDerpu
Copy link
Author

oh yeah dw about it being delayed haha, im in no rush, but thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instrument request Request an addition of a new instrument
Projects
None yet
Development

No branches or pull requests

2 participants