Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install script is not working when api returns rate limit #16

Open
Seraphli opened this issue Jun 28, 2024 · 3 comments
Open

install script is not working when api returns rate limit #16

Seraphli opened this issue Jun 28, 2024 · 3 comments

Comments

@Seraphli
Copy link

decky loader is not loaded after I update to beta channel (3.6.8). I try to install pre-release version. The installation didn't pop up any error. But the decky loader still didn't show up.
There is a jq error.
jq: error (at <stdin>:1): Cannot index string with string prerelease.
It seems accessing https://api.github.com/repos/SteamDeckHomebrew/decky-loader/releases returns a rate limit error, so the script didn't work.

@TrainDoctor
Copy link
Member

@PartyWumpus if you could add some logic to detect the API rate limit that would be appreciated. @Seraphli, we can't do much about the rate limit itself though since that's a GitHub issue and we don't and won't pay for additional API access.

@Seraphli
Copy link
Author

Seraphli commented Aug 1, 2024

Yeah I get it. It would be good if this script could add an input for the GitHub token, or you could manually fill in the version. Alternatively, it could just check if the download fails and skip the subsequent operations if it does. This way, it can prevent the deletion of the current loader.

@TrainDoctor
Copy link
Member

TrainDoctor commented Aug 1, 2024

Yeah I get it. It would be good if this script could add an input for the GitHub token, or you could manually fill in the version. Alternatively, it could just check if the download fails and skip the subsequent operations if it does. This way, it can prevent the deletion of the current loader.

Edit: Implementing an API token option is highly specific in it's nature and doubt we will actually need something like that.

The script does not delete anything until it finishes the download to my knowledge but Party is the maintainer for the installer and would need to confirm that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants