Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

playwright testing dictionary import #19

Open
wants to merge 15 commits into
base: master-clone
Choose a base branch
from
Open

playwright testing dictionary import #19

wants to merge 15 commits into from

Conversation

StefanVukovic99
Copy link
Owner

No description provided.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 16, 2024 •
edited
Loading

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 6 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks
  • Loop 1 through 100,000 (20.8 ms)
  • japanese transformations (n=57) (14.8 ms)
  • japanese transformations-full (n=156) (32.1 ms)
  • spanish transformations (n=97) (14.2 ms)
  • Translator.prototype.findKanji - (n=3) (2.9 ms)
  • Translator.prototype.findTerms - (n=43) (150.6 ms)

khaitruong922 and others added 11 commits July 16, 2024 17:09
@khaitruong922
When no dictionary is enabled, update preview after enable dictionary (…
22da9df 
…FooSoft#1232)

* Fix preview not update when enable dictionary

* Add dictionaryEnabled event

* Update logic

* align

* Fix lint
@MarvNC
Set Empty Default Font (FooSoft#1234)
6519c47 
* Set Empty Default Font

* Fix test

* Add new version upgrade instead
@StefanVukovic99
[it] preprocess italian diacritics (FooSoft#1237)
5b565ad
@Casheeew
Stricten condition types (FooSoft#1229)
4e581e7 
* stricten condition types

* remove vestigial code

* update german

* update language transformer

* update language transformer cycle test

* clean up types

* remove vestigial import

* add default type to generic

* update docs

* add missing docs

* fix formatting
@Kuuuube
Fix audio menu z-index (FooSoft#1240)
f43cfd0
@StefanVukovic99
playwright test importing from url and deleting dictionary (FooSoft#1233
f2632ef 
)

* try testing url import in playwright

* try fixes

* fixes

* try fixing button

* try fixing button

* try fixing button

* test deleting

* test deleting

* test deleting

* typo
@StefanVukovic99
Merge branch 'master' into download-progress
689fa65
@Kuuuube
Prevent popup scaling from throwing errors constantly (FooSoft#1241)
60b0a39
@StefanVukovic99
better error handling
f0391b9
@StefanVukovic99
Merge branch 'master' into download-progress
c1a189a
@StefanVukovic99
simplify DictionaryCount
3d3f6d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StefanVukovic99 @khaitruong922 @MarvNC @Casheeew @Kuuuube