Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter popovers do not resize on rotation #2773

Closed
drewvolz opened this issue Aug 11, 2018 · 4 comments
Closed

Filter popovers do not resize on rotation #2773

drewvolz opened this issue Aug 11, 2018 · 4 comments
Labels
component/filter Related to the Filter view

Comments

@drewvolz
Copy link
Member

8fc23ce8-36d3-43a4-b235-480bcb23d380

Can we fix this the way we’ve fixed other rotation views?

@drewvolz drewvolz assigned drewvolz and unassigned drewvolz Aug 11, 2018
@drewvolz drewvolz added the component/filter Related to the Filter view label Aug 11, 2018
@drewvolz drewvolz removed their assignment Aug 11, 2018
@hannesmcman
Copy link
Member

I think, similar to #2764, this calls for a PR to https://github.com/SteffeyDev/react-native-popover-view. The anchor point needs to be recalculated on the rotation event, which seems like a problem for the library itself. Thoughts?

@hawkrives
Copy link
Member

I concur that this should be solved in the library.

@hannesmcman
Copy link
Member

Looks like there's a related issue in the repo already: SteffeyDev/react-native-popover-view#2

@hannesmcman
Copy link
Member

@hawkrives @drewvolz Orrr we could just wrap the FilterPopover component with Viewport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/filter Related to the Filter view
Projects
None yet
Development

No branches or pull requests

3 participants