Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit and ros lint #30

Open
wants to merge 4 commits into
base: ros2_control_support_package_added
Choose a base branch
from

Conversation

muritane
Copy link

@muritane muritane commented May 30, 2023

Main changes:

  • kuka_eki_hw_interface.h -> kuka_eki_hw_interface.hpp
  • sort includes
  • unsigned long long -> uint64_t
  • unsigned short -> uint16_t
  • /* -> // as these comment blocks are not recognized by ament_copyright
  • "Software License Agreement" should be after "Copyright (c)" to be recognized by ament_copyright
  • BSD License -> BSD License 2.0 (@destogl is this 2.0 ok or should it be other clause?)
  • ReflowComments: false -> true
  • Ignore flake8 W503: Line break occurred before a binary operator as it is outdated and goes against the PEP 8 recommended style (should be reactivated after update)
  • add packages to ci ros lint

@muritane muritane changed the title [kuka_ros2_control_support] Fix precommit Fix pre-commit and ros lint May 31, 2023
@muritane muritane requested a review from destogl May 31, 2023 10:52
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the changes on EKI stuff – they should be in a separate PR toward rolling. We don't want to address them here. (If there are some changes in #12 I will remove them.)

The correct license is 3-Clause BSD License

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants