Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rolling] fix pre-commit #32

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

muritane
Copy link

@muritane muritane commented Jun 9, 2023

Main changes:

  • kuka_eki_hw_interface.h -> kuka_eki_hw_interface.hpp
  • sort includes
  • unsigned long long -> uint64_t
  • unsigned short -> uint16_t
  • /* -> // as these comment blocks are not recognized by ament_copyright
  • "Software License Agreement" should be after "Copyright (c)" to be recognized by ament_copyright
  • BSD License -> BSD License 2.0 (@destogl is this 2.0 ok or should it be other clause?)
  • ReflowComments: false -> true
  • Ignore flake8 W503: Line break occurred before a binary operator as it is outdated and goes against the PEP 8 recommended style (should be reactivated after update)
  • add packages to ci ros lint

Co-authored-by: Dr. Denis <[email protected]>
@muritane muritane force-pushed the fix_precommit_rolling branch from 3178fd0 to efe5597 Compare June 9, 2023 14:28
@muritane muritane changed the title fix pre-commit [rolling] fix pre-commit Jun 9, 2023
@muritane muritane requested a review from destogl June 14, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant