New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php 8.4 compatibility #15

Open

jacekkarczmarczyk opened this issue Feb 27, 2025 · 0 comments · May be fixed by #16

jacekkarczmarczyk commented Feb 27, 2025

Hello there, there are few places where PHP 8.4 throws a warning Implicitly marking parameter ... as nullable is deprecated, ex.

https://github.com/Strobotti/php-jwk/blob/master/src/Key/AbstractKey.php#L168
https://github.com/Strobotti/php-jwk/blob/master/src/Key/Rsa.php#L103

It might be worth to update the CI to check for these warning in other places as well

The text was updated successfully, but these errors were encountered:

jacekkarczmarczyk linked a pull request

that will close this issue

fix: php 8.4 compatibility #16

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment