We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I took a look at the com.strumenta.kolasu.lionweb, and found a few improvements I suggest to implement:
when
if-else
.asJsonObject
is
@Synchronized
synchronized
in
containsKeys()
try
finally
A PR will follow
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I took a look at the com.strumenta.kolasu.lionweb, and found a few improvements I suggest to implement:
when
statements instead of nestedif-else
ones, e.g. in JSONComparison.asJsonObject
in favor ofis
smart-casting, e.g. in JSONComparison@Synchronized
instead of explicitsynchronized
blocks, e.g. in BiMapin
operator instead ofcontainsKeys()
, e.g. in BiMaptry
-finally
block where operations are executed, e.g. in PerformanceLogger#logA PR will follow
The text was updated successfully, but these errors were encountered: