Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL multithreading #45

Open
Aidan-Stephenson opened this issue May 12, 2024 · 0 comments
Open

SQL multithreading #45

Aidan-Stephenson opened this issue May 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Aidan-Stephenson
Copy link
Collaborator

Describe the bug
Currently, each worker process has its own sql connection with thread checking enabled (but connection shared beyond that). While this works most of the time, during the git update cycle a new thread is created, violating the same-thread constraint.

This needs to be fixed on two levels:

  1. if an update fails, the git repo needs to be rolled back so it can be attempted again
  2. The git update thread needs its own connection. (And in general database.py should probably be rewritten)

To Reproduce
Steps to reproduce the behavior:

  1. Run in production mode
  2. Induce a git update

Expected behavior
Git update to happen, regardless of failure

@Aidan-Stephenson Aidan-Stephenson added the bug Something isn't working label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant