Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor file paths #54

Open
delta6862 opened this issue Aug 18, 2024 · 0 comments
Open

Refactor file paths #54

delta6862 opened this issue Aug 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@delta6862
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently the docker-compose volume mapping looks like

    volumes:
      - ./data/pages:/webapp/pages:ro
      - ./data/writeups:/webapp/writeups
      - ./data/db:/webapp/db
      - ./data/challenges/:/tmp/challenges:ro
      - ./data/.git-credentials:/root/.git-credentials:ro
      - ./webapp/templates/:/webapp/templates:ro
      - ./webapp/static/:/webapp/static
      - ./data/config.json:/webapp/config.json:ro

With the exception of .git-credentials these paths don't need to be remapped (/data/config.json can be mapped to /webapp/data/config.json in the docker container, instead of the current /webapp/config.json)

Describe the solution you'd like
Ideally we mirror the folder structure in and outside of the docker container. Making development and testing easier. There are a few edge cases revolving around git that we need to consider. Like the git-credentials and docker escapes through git hooks (https://book.hacktricks.xyz/linux-hardening/privilege-escalation/write-to-root).

Describe alternatives you've considered
This is not a high priority change, as the intended way of running pwncrates is through docker-compose. But it simplifies the folder mapping, which in my eyes is a good thing.

@delta6862 delta6862 added the enhancement New feature or request label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant