Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL in annotation: clickable link mistakenly converted into normal text #242

Closed
RESL opened this issue Sep 9, 2020 · 2 comments
Closed
Assignees

Comments

@RESL
Copy link
Contributor

RESL commented Sep 9, 2020

Tested on branch feat/extra (c488626)

URL mistakenly converted into normal text, when it should remain clickable Link.

Here is a step-by-step explanation for reproduction:

  1. Reset to sample project.
  2. Select text field of empty annotation (in red track, starting at 00:00:06.736, ending at 00:00:21.197)
  3. add URL https://process.studio/ as annotation text
  4. select annotation beneath by left-clicking annotation in yellow track -> URL in previous annotation is converted into clickable Link (correct)
  5. Select original annotation again (not textfield of that annotation) -> URL is converted back into normal text, not clickable (wrong)
  6. Select different annotation -> URL is still normal text, should be clickable Link (wrong)

Clickable URLs should only be converted into normal text, when text field of annotation is selected (i.e. while typing). If anything else is selected (another annotation or anything else in same annotation other than the textfield), URL should remain clickable link.

Here is a step-by-step explanation for reproduction (with screenshots):

1. Reset to sample project.

2. Select text field of empty annotation (in red track, starting at 00:00:06.736, ending at 00:00:21.197)
Screenshot 2020-09-09 at 10 39 39

3. add URL https://process.studio/ as annotation text
Screenshot 2020-09-09 at 10 39 55

4. select annotation beneath by left-clicking annotation in yellow track -> URL in previous annotation is converted into clickable Link (correct)
Screenshot 2020-09-09 at 10 40 09

5. Select original annotation again (not textfield of that annotation) -> URL is converted back into normal text, not clickable (wrong)
Screenshot 2020-09-09 at 10 40 20

6. Select different annotation -> URL is still normal text, should be clickable Link (wrong)
Screenshot 2020-09-09 at 10 40 57

@RESL
Copy link
Contributor Author

RESL commented Sep 18, 2020

Issue fixed except for one case:

  • Repeat steps 1. - 3. (see above)
  • After clicking on link in annotation (new tab opens) and returning to RV tab, the clicked link is mastakenly converted into normal text again

@martinleopold
Copy link
Member

Tested after update; Fixed (eeda7a5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants