#02 인기영화 목록 보기 및 영화 상세보기 화면 제공 #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1 프로젝트 초기 구성
Hoyuo
reviewed
Apr 8, 2020
ToyProject/app/build.gradle
Outdated
|
|
||
| android { | ||
| compileSdkVersion 29 | ||
| buildToolsVersion "29.0.3" |
There was a problem hiding this comment.
buildToolsVersion은 없어도 됩니다.
한번 찾아보시면 공부하는데 도움이 될꺼같습니다.
There was a problem hiding this comment.
gradle 3.x 이후 부터 적용하지 않아도 된다고 하는데 이게 맞나요?
| import androidx.recyclerview.widget.ListAdapter | ||
| import androidx.recyclerview.widget.RecyclerView | ||
|
|
||
| abstract class BaseRecyclerView { |
There was a problem hiding this comment.
BaseRecyclerView class 가 필요한지가 의문입니다
There was a problem hiding this comment.
맞네요 습관처럼 만들다보니 인지하지 못하고 있었습니다. 수정했습니다
|
disposable 관리에 대해서는 좀 더 이야기가 필요 하다고 생각됩니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
리뷰 부탁드립니다
