generated from StuyPulse/Phil
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JW/RX - LEDController + Rainbow LEDs #174
Open
Keobkeig
wants to merge
45
commits into
main
Choose a base branch
from
jw-rx/LED-controller
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Richie Xue <[email protected]>
Co-authored-by: Richie Xue <[email protected]>
…jw-rx/LED-controller
selym3
requested changes
Apr 5, 2023
src/main/java/com/stuypulse/robot/commands/leds/LEDSetPulseRed.java
Outdated
Show resolved
Hide resolved
Co-authored-by: colyic <[email protected]> Co-authored-by: Souvik Basak <[email protected]> Co-authored-by: Ian Shi <[email protected]> Co-authored-by: Kalimul <[email protected]> Co-authored-by: Mustafa <[email protected]>
Co-authored-by: colyic <[email protected]> Co-authored-by: Souvik Basak <[email protected]> Co-authored-by: Ian Shi <[email protected]> Co-authored-by: Kalimul <[email protected]> Co-authored-by: Mustafa <[email protected]>
…jw-rx/LED-controller
- changed LEDRainbow to use SLColor
Co-authored-by: anivanchen <[email protected]>
* Add against grid debouncer in AlignThenScore * Copy derivative into util and add getOutput * Fixes --------- Co-authored-by: BenG49 <[email protected]>
…x/LED-controller
Co-authored-by: bananaeater321 <[email protected]>
- SLColor (to be added to StuyLib) as util color class - constants/LEDColor to store color consts - LEDSingleColor instead for single color LEDS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Split LEDcontrlller into abstract class and then extends into LEDcontrollerImpl and SimLED
-Created Rainbow class to setLED into rainbow
-Made a command for setting rainbow
-Changed container to have right button set LED colour into rainbow
(last merge request was showing the wrong commits, this one should be the right changes made)