Skip to content

Commit

Permalink
fix: ensure that compute functions are running as non-root (#228)
Browse files Browse the repository at this point in the history
Signed-off-by: SdgJlbl <[email protected]>
  • Loading branch information
SdgJlbl authored Jul 23, 2024
1 parent c4bdf50 commit 1412f88
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 0 deletions.
4 changes: 4 additions & 0 deletions changes/228.fixed
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Add a non-root user to the generated Dockerfile for the compute functions.

Compute pods were already running as non-root (ensured by a security context in the backend), we are making it more
explicit here.
7 changes: 7 additions & 0 deletions substrafl/remote/register/register.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,13 @@
# update image
RUN apt update -y
# create a non-root user
RUN addgroup --gid 1001 group
RUN adduser --disabled-password --gecos "" --uid 1001 --gid 1001 --home /home/user user
ENV PYTHONPATH /home/user
WORKDIR /home/user
USER user
# install dependencies
RUN python{python_version} -m pip install -U pip
Expand Down
7 changes: 7 additions & 0 deletions tests/remote/register/test_register.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ def test_create_dockerfile(tmp_path, mocker, local_installable_module):
# update image
RUN apt update -y
# create a non-root user
RUN addgroup --gid 1001 group
RUN adduser --disabled-password --gecos "" --uid 1001 --gid 1001 --home /home/user user
ENV PYTHONPATH /home/user
WORKDIR /home/user
USER user
# install dependencies
RUN python{python_version} -m pip install -U pip
Expand Down

0 comments on commit 1412f88

Please sign in to comment.